New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move SSL key delete form to side panel #5341

Merged

Jay-Topher merged 1 commit into canonical:main from Jay-Topher:MAASENG-2814-move-ssl-delete-confirmation-to-sidepanel

Mar 12, 2024

Contributor

Jay-Topher commented Mar 12, 2024

Done

Moved SSL key delete form to side panel

QA steps

Visit /account/prefs/ssl-keys
Add an SSL key (you can make one here)
Click on the delete button for the created SSL key
Ensure that the delete confirmation is in a side panel
Click the delete button
Ensure that the SSL key is deleted and the relevant notification is displayed
Ensure the side panel closes after successful deletion

Fixes

Fixes: Dev: Display SSL Key delete confirmation in a side panel

Screenshots

Before

After

Notes


          feat: move ssl key delete form to side panel

8ec4252

Jay-Topher added Review: Code needed Review: QA needed labels

Jay-Topher requested review from petermakowski and ndv99

March 12, 2024 12:28

webteam-app commented Mar 12, 2024

Demo starting at https://maas-ui-5341.demos.haus

ndv99 approved these changes

View reviewed changes

Contributor

ndv99 left a comment

LGTM

ndv99 added Review: Code +1 Review: QA +1 and removed Review: Code needed Review: QA needed labels

Jay-Topher merged commit 44d7ffb into canonical:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: Code +1 Review: QA +1